Re: [PATCH] Add the GIT_SENTINEL macro

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2013, 03:30 UTC
Message-ID: <7vr4evz0oc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51E849C4.7020305@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 11 quoted lines

> The sentinel function attribute is not understood by versions of
> the gcc compiler prior to v4.0. At present, for earlier versions
> of gcc, the build issues 108 warnings related to the unknown
> attribute. In order to suppress the warnings, we conditionally
> define the GIT_SENTINEL macro to provide the sentinel attribute
> for gcc v4.0 and newer.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> This was built on the next branch

It seems to apply well on the tip of jk/gcc-function-attributes.

 - This macro is not about "git" at all, so I'll edit the patch to
   call it GCC_ATTR_SENTINEL before applying.

 - Also I'll drop the (0) at the end.

Thanks.