Re: [PATCH] Add the GIT_SENTINEL macro

From: Jeff King <peff@peff.net>
Date: Jul 18, 2013, 20:31 UTC
Message-ID: <20130718203150.GA15735@sigill.intra.peff.net>
In-Reply-To: <51E849C4.7020305@ramsay1.demon.co.uk>

On Thu, Jul 18, 2013 at 09:02:12PM +0100, Ramsay Jones wrote:

Show 9 quoted lines

> The sentinel function attribute is not understood by versions of
> the gcc compiler prior to v4.0. At present, for earlier versions
> of gcc, the build issues 108 warnings related to the unknown
> attribute. In order to suppress the warnings, we conditionally
> define the GIT_SENTINEL macro to provide the sentinel attribute
> for gcc v4.0 and newer.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---

Acked-by: Jeff King <peff@peff.net>

> -__attribute__((sentinel))
> +GIT_SENTINEL(0)
>  void argv_array_pushl(struct argv_array *, ...);

We could also add GIT_SENTINEL to handle the default-zero case, but I do not think it is worth the trouble.

-Peff