git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff.c: respect diff.renames config option

From
Junio C Hamano <junkio@cox.net>
Date
Jul 7, 2006, 11:18 UTC
Message-ID
<7vpsghzmr1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060707110123.GA23400@soma>
Eric Wong <normalperson@yhbt.net> writes:
> Nevertheless, it's still opt -in via repo-config, and most people will
> find renames useful unless they need to export to non-git
> systems.

I am more worried about somebody who opts-in finds breakage of commands that happen to internally use low-level diff machinery and expect the diff machinery does not automagically do funny rename detection without being told.

For example, revision walking with path pruning uses diff machinery without renames. I do not know what happens if I override it with diff.renames to allow rename detection but I fear something might horribly break.

That is why I said I do not want this at _that_ low level. I do not have objections to have the configuration at a layer closer to the UI, e.g. things in builtin-log.c and builtin-diff.c.

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 13 in “I forgot to run format-patch with the -M flag”
  1. 0/1 I forgot to run format-patch with the -M flagEric Wong, Jul 7, 2006
  2. diff.c: respect diff.renames config optionEric Wong, Jul 7, 2006
  3. builtin-log: respect diff configuration optionsEric Wong, Jul 7, 2006
  4. Junio C HamanoJul 7, 2006
  5. Junio C HamanoJul 7, 2006
  6. Junio C HamanoJul 7, 2006
  7. Junio C HamanoJul 7, 2006
  8. Fix several places where diff.renames in config can be problematicEric Wong, Jul 8, 2006
  9. Junio C HamanoJul 8, 2006
  10. Eric WongJul 8, 2006
  11. templates/hooks--update: replace diffstat calls with git diff --statEric Wong, Jul 8, 2006
  12. Junio C HamanoJul 7, 2006
  13. update Documentation/diff-options.txtJunio C Hamano, Jul 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.