git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] diff.c: respect diff.renames config option

From
EWEric Wong <normalperson@yhbt.net>
Date
Jul 7, 2006, 10:10 UTC
Message-ID
<11522670473116-git-send-email-normalperson@yhbt.net>
In-Reply-To
<11522670452824-git-send-email-normalperson@yhbt.net>

diff.renames is mentioned several times in the documentation, but to my surprise it didn't do anything before this patch.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 Documentation/config.txt |    5 +++++
 diff.c                   |   12 ++++++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index f075f19..5290a8f 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -114,6 +114,11 @@ diff.renameLimit::
 	The number of files to consider when performing the copy/rename
 	detection; equivalent to the git diff option '-l'.
 
+diff.renames::
+	Tells git to detect renames.  If set to any boolean value, it
+	will enable basic rename detection.  If set to "copies" or
+	"copy", it will detect copies, as well.
+
 format.headers::
 	Additional email headers to include in a patch to be submitted
 	by mail.  See gitlink:git-format-patch[1].
diff --git a/diff.c b/diff.c
index 507e401..223622a 100644
--- a/diff.c
+++ b/diff.c
@@ -13,6 +13,7 @@ #include "xdiff-interface.h"
 
 static int use_size_cache;
 
+static int diff_detect_rename_default = 0;
 static int diff_rename_limit_default = -1;
 static int diff_use_color_default = 0;
 
@@ -120,6 +121,16 @@ int git_diff_config(const char *var, con
 			diff_use_color_default = git_config_bool(var, value);
 		return 0;
 	}
+	if (!strcmp(var, "diff.renames")) {
+		if (!value)
+			diff_detect_rename_default = DIFF_DETECT_RENAME;
+		else if (!strcasecmp(value, "copies") ||
+			 !strcasecmp(value, "copy"))
+			diff_detect_rename_default = DIFF_DETECT_COPY;
+		else
+			diff_detect_rename_default = git_config_bool(var,value);
+		return 0;
+	}
 	if (!strncmp(var, "diff.color.", 11)) {
 		int slot = parse_diff_color_slot(var, 11);
 		diff_colors[slot] = parse_diff_color_value(value, var);
@@ -1429,6 +1440,7 @@ void diff_setup(struct diff_options *opt
 	options->change = diff_change;
 	options->add_remove = diff_addremove;
 	options->color_diff = diff_use_color_default;
+	options->detect_rename = diff_detect_rename_default;
 }
 
 int diff_setup_done(struct diff_options *options)
-- 
1.4.1.g3dc65
Previous: Eric WongNext: Eric Wong
Message 2 of 13 in “I forgot to run format-patch with the -M flag”
  1. 0/1 I forgot to run format-patch with the -M flagEric Wong, Jul 7, 2006
  2. diff.c: respect diff.renames config optionEric Wong, Jul 7, 2006
  3. builtin-log: respect diff configuration optionsEric Wong, Jul 7, 2006
  4. Junio C HamanoJul 7, 2006
  5. Junio C HamanoJul 7, 2006
  6. Junio C HamanoJul 7, 2006
  7. Junio C HamanoJul 7, 2006
  8. Fix several places where diff.renames in config can be problematicEric Wong, Jul 8, 2006
  9. Junio C HamanoJul 8, 2006
  10. Eric WongJul 8, 2006
  11. templates/hooks--update: replace diffstat calls with git diff --statEric Wong, Jul 8, 2006
  12. Junio C HamanoJul 7, 2006
  13. update Documentation/diff-options.txtJunio C Hamano, Jul 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.