From: Junio C Hamano <junkio@cox.net>
Date: Fri, 07 Jul 2006 11:18:42 GMT
Subject: Re: [PATCH] diff.c: respect diff.renames config option
Message-ID: <7vpsghzmr1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060707110123.GA23400@soma>

Eric Wong <normalperson@yhbt.net> writes:

> Nevertheless, it's still opt -in via repo-config, and most people will
> find renames useful unless they need to export to non-git
> systems.

I am more worried about somebody who opts-in finds breakage of
commands that happen to internally use low-level diff machinery
and expect the diff machinery does not automagically do funny
rename detection without being told.

For example, revision walking with path pruning uses diff
machinery without renames.  I do not know what happens if I
override it with diff.renames to allow rename detection but I
fear something might horribly break.

That is why I said I do not want this at _that_ low level.  I do
not have objections to have the configuration at a layer closer
to the UI, e.g. things in builtin-log.c and builtin-diff.c.