Re: *[PATCH 2/2] Let git-add--interactive read colors from .gitconfig
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 3, 2007, 18:11 UTC
- Message-ID
- <7vpryrxkqm.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071103022626.253dcd93@paradox.zwell.net>
Dan Zwell <dzwell@zwell.net> writes:
Show 8 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote: > ... >> In addition to a small matter of testing, a more practical issue >> would be to add PAGER support there, I think. > > You mean in general, so that users can view a hunk in the PAGER, then > be prompted for what to do with it? (Because it doesn't solve the color > problems, because calling "diff --color" here creates other problems.)
Yes. I see it a much bigger problem that we let a long hunk scroll off the top of the screen then ask the user what to do with it, than any coloring of diff.
> ... but it does not highlight > whitespace at the end of lines or space/tab errors.
No, but you can make it so if you want.
Personally, I think it is not so useful for "add -i" to do so, as it is too late in the workflow, unless you add it ways to let you edit and fix the whitespace errors.