Re: [PATCH] Color support added to git-add--interactive.

From: Jeff King <peff@peff.net>
Date: Oct 15, 2007, 04:12 UTC
Message-ID: <20071015041202.GA5939@coredump.intra.peff.net>
In-Reply-To: <19271E58-5C4F-41AF-8F9D-F114F36A34AC@wincent.com>

On Sat, Oct 13, 2007 at 04:45:41PM +0200, Wincent Colaiuta wrote:

> - changed the regex as suggested by Johannes, and a couple of others
> that are used when splitting hunks

BTW, this approach is totally bogus. The hunks that we store end up getting fed back to git-apply when we stage them (which doesn't understand the color codes).

Just try using your patch to actually stage a hunk; nothing happens (and the error is almost impossible to see, since we show the bogus diff on stderr).

So now I am doubly convinced that colorizing the diffs in add--interactive is the right thing (and it looks like Tom Tobin has already done a fair bit of the work).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.