Re: [PATCH 5/5] Added diff hunk coloring to git-add--interactive

From: Jeff King <peff@peff.net>
Date: Nov 23, 2007, 10:21 UTC
Message-ID: <20071123102156.GA6754@sigill.intra.peff.net>
In-Reply-To: <7v1wai3qrw.fsf@gitster.siamese.dyndns.org>

On Thu, Nov 22, 2007 at 01:37:55PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> > Unfortunately, there is a historical wart that probably still needs
> > supporting, which is that the original names were diff.color.*. Or have
> > we officially removed support for that yet?
> 
> Neither officially or unofficially yet, but we can start the
> process of making it official with an early announcement.  I do
> not think we would hurt people as long as a long enough advance
> notice is given.

Andy Parkins added color.* (and removed documentation for *.color) almost a year ago (in a159ca0c). But I don't think there has been an official deprecation notice.

Show 5 quoted lines

> I however am wondering if we need to have so many "enable color
> support" switches.  color.status, color.diff, and now yet
> another color.interactive?  Who sets color.status and/or
> color.interactive to auto without setting color.diff to auto as
> well?

Yes, I have often thought this, as well, and a "color.all" would probably be convenient.

-Peff