Re: [PATCH 1/3] test-lib: tests can have multiple prerequisites

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2010, 00:06 UTC
Message-ID: <7vpr1liwrk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100426191703.GC10772@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> I do wonder if it might be less error-prone to have:
>
>   test_expect_success PREREQ1 PREREQ2 'desc' 'test'
>
> instead of
>
>   test_expect_success 'PREREQ1 PREREQ2' 'desc' 'test'

Spot what is wrong with this:

        test_expect_success make sure we have the repo '
                test -d .git
        '

I think "we may or may not have a single prereq word" would be less error prone. (you could make sure "test_have_prereq" gets no lowercase letter to mitigate the issue, though).

I tend to like the comma myself, but quoted, space separated list is fine by me.