git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] t1004 (read-tree): the unremovable symlink test requires POSIXPERM

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 21, 2010, 13:44 UTC
Message-ID
<20100421134457.GB5595@progeny.tock>
In-Reply-To
<20100421131255.GA2750@progeny.tock>

Now that it is possible to express this, declare the test from 8a785dc (Add tests to catch problems with un-unlinkable symlinks, 2008-03-18) to require both POSIXPERM and SYMLINKS.

This test would fail on Windows on filesystems that do support symbolic links and in other situations where symlinks are usable but Unix-style permissions are not.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
It seems that an almost identical patch was submitted while the
prerequisite mechanism was in its infancy.
http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385
 t/t1004-read-tree-m-u-wf.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t1004-read-tree-m-u-wf.sh b/t/t1004-read-tree-m-u-wf.sh
index f19b4a2..62854a7 100755
--- a/t/t1004-read-tree-m-u-wf.sh
+++ b/t/t1004-read-tree-m-u-wf.sh
@@ -177,7 +177,7 @@ test_expect_success SYMLINKS 'funny symlink in work tree' '
 
 '
 
-test_expect_success SYMLINKS 'funny symlink in work tree, un-unlink-able' '
+test_expect_success 'POSIXPERM SYMLINKS' 'funny symlink in work tree, un-unlink-able' '
 
 	rm -fr a b &&
 	git reset --hard &&
-- 
1.7.1.rc1
Previous: Jeff KingNext: Jonathan Nieder
Message 7 of 8 in “running tests as fakeroot”
  1. 0/3 running tests as fakerootJonathan Nieder, Apr 21, 2010
  2. 1/3 test-lib: tests can have multiple prerequisitesJonathan Nieder, Apr 21, 2010
  3. Jonathan NiederApr 21, 2010
  4. Jeff KingApr 26, 2010
  5. Junio C HamanoApr 27, 2010
  6. Jeff KingApr 27, 2010
  7. 2/3 t1004 (read-tree): the unremovable symlink test requires POSIXPERMJonathan Nieder, Apr 21, 2010
  8. 3/3 Permit tests to be run as a (fake) root userJonathan Nieder, Apr 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.