Re: [PATCH 1/3] test-lib: tests can have multiple prerequisites

From: Jeff King <peff@peff.net>
Date: Apr 26, 2010, 19:17 UTC
Message-ID: <20100426191703.GC10772@coredump.intra.peff.net>
In-Reply-To: <20100421133806.GA5595@progeny.tock>

On Wed, Apr 21, 2010 at 08:38:06AM -0500, Jonathan Nieder wrote:

Show 8 quoted lines

> Alas, I didn’t notice the thread with the almost identical patch [1]
> before writing this one.
> 
> Since I am painting it, I prefer this way.  I find it intuitive and
> can’t really see where the fuss about using some other coding style
> came from.  So I would be very happy if someone who does understand
> the fuss could come up with a comment to add to the commit message
> about this. :)

I liked commas better, but since you are doing the work of writing the patches, I will let it go. :)

I do wonder if it might be less error-prone to have:

  test_expect_success PREREQ1 PREREQ2 'desc' 'test'

instead of

  test_expect_success 'PREREQ1 PREREQ2' 'desc' 'test'

which should just be something like

  while test $# -gt 2; do
    test_have_prereq "$1" || skip=t
    shift
  done

But if you think that's dumb, just ignore it. It is really not worth spending that much time on.

-Peff