git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] Documentation: Add filter.<driver>.* to config

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 6, 2011, 16:50 UTC
Message-ID
<7vpqozjpcl.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110406124235.GA5881@kytes>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 8 quoted lines
> I'm very sorry to have caused so much pain.  Yes, I can imagine how
> terrible it must be to review several iterations of a simple
> documentation patch.  Thank you for being so patient with me so far- I
> understand if you don't want to do this anymore.
>
> I do spend time proofreading patches before sending them out, but I'm
> clearly not very good at it.  In future, I'll either try rewriting
> entire paragraphs or simply refrain from writing documentation patches.

I do not think that is the lesson you should learn from this exchange. A major part of Michael's complaint (which I think was justified) was that he even made a suggestion that is ready to be cut-and-pasted, but your reroll does not use the suggested phrasing _without_ explaining why it doesn't.

It is not limited to "documentation patches". If you get a "how about doing it this way---isn't it cleaner?" suggestion to your code patch, you at least owe either "yeah, that looks better---thanks, I've used it in this reroll" or "no, because...; I've used the original" to the person who tried to help you, no?

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 18 of 33 in “Documentation: Document diff.<tool>.* and filter.<driver>.* in config”
  1. Documentation: Document diff.<tool>.* and filter.<driver>.* in configRamkumar Ramachandra, Apr 1, 2011
  2. Jakub NarebskiApr 1, 2011
  3. Documentation: Document diff.<tool>.* and filter.<driver>.* in configRamkumar Ramachandra, Apr 1, 2011
  4. Jakub NarebskiApr 1, 2011
  5. Michael J GruberApr 1, 2011
  6. 0/3 Document diff and filter drivers in configRamkumar Ramachandra, Apr 3, 2011
  7. 1/3 Documentation: Add filter.<driver>.* to configRamkumar Ramachandra, Apr 3, 2011
  8. Michael J GruberApr 4, 2011
  9. 2/3 Documentation: Add diff.<driver>.* to configRamkumar Ramachandra, Apr 3, 2011
  10. Michael J GruberApr 4, 2011
  11. Junio C HamanoApr 4, 2011
  12. 3/3 Documentation: Allow custom diff tools to be specified in 'diff.tool'Ramkumar Ramachandra, Apr 3, 2011
  13. Michael J GruberApr 4, 2011
  14. 0/4 Document diff and filter drivers in configRamkumar Ramachandra, Apr 6, 2011
  15. 1/4 Documentation: Add filter.<driver>.* to configRamkumar Ramachandra, Apr 6, 2011
  16. Michael J GruberApr 6, 2011
  17. Ramkumar RamachandraApr 6, 2011
  18. Junio C HamanoApr 6, 2011
  19. Ramkumar RamachandraApr 6, 2011
  20. Michael J GruberApr 7, 2011
  21. Ramkumar RamachandraApr 7, 2011
  22. 2/4 Documentation: Add diff.<driver>.* to configRamkumar Ramachandra, Apr 6, 2011
  23. 3/4 Documentation: Allow custom diff tools to be specified in 'diff.tool'Ramkumar Ramachandra, Apr 6, 2011
  24. 4/4 Documentation: Minor language improvements to merge-configRamkumar Ramachandra, Apr 6, 2011
  25. 0/4 Document diff and filter drivers in configRamkumar Ramachandra, Apr 6, 2011
  26. 1/4 Documentation: Add filter.<driver>.* to configRamkumar Ramachandra, Apr 6, 2011
  27. 2/4 Documentation: Add diff.<driver>.* to configRamkumar Ramachandra, Apr 6, 2011
  28. Junio C HamanoApr 6, 2011
  29. Ramkumar RamachandraApr 7, 2011
  30. 3/4 Documentation: Allow custom diff tools to be specified in 'diff.tool'Ramkumar Ramachandra, Apr 6, 2011
  31. 4/4 Documentation: Minor language improvements to merge-configRamkumar Ramachandra, Apr 6, 2011
  32. Michael J GruberApr 7, 2011
  33. Michael J GruberApr 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.