Re: [PATCH 1/3] Documentation: Add filter.<driver>.* to config

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Apr 4, 2011, 08:46 UTC
Message-ID: <4D99854B.70801@drmicha.warpmail.net>
In-Reply-To: <1301840722-24344-2-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra venit, vidit, dixit 03.04.2011 16:25:

Show 22 quoted lines

> Although the gitattributes page contains comprehensive information
> about these configuration options, they should be included in the
> config documentation for completeness.
> 
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  Documentation/config.txt |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 8ea55d4..711072c 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -973,6 +973,16 @@ format.signoff::
>      the rights to submit this work under the same open source license.
>      Please see the 'SubmittingPatches' document for further discussion.
>  
> +filter.<driver>.clean::
> +	Defines the command to be used to convert the contents of
> +	worktree file upon checkin.  See linkgit:gitattributes[5] for
> +	details.
> +

Here we go again :) I rever Desmond Tutu, I dislike "to... to"... And articles. Also, every option "defines" something, no need to say that:

The command which is used to convert the content of a worktree file to a blob upon checkin.

Show 5 quoted lines

> +filter.<driver>.smudge::
> +	Defines the command to be used to convert the blob object to
> +	worktree file upon checkout.  See linkgit:gitattributes[5] for
> +	details.
> +

The command which is used to convert the content of a blob object to a worktree file upon checkout.

>  gc.aggressiveWindow::
>  	The window size parameter used in the delta compression
>  	algorithm used by 'git gc --aggressive'.  This defaults