Re: [PATCH 1/4] Documentation: Add filter.<driver>.* to config

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Apr 6, 2011, 11:27 UTC
Message-ID: <4D9C4E0F.8050302@drmicha.warpmail.net>
In-Reply-To: <1302083854-2448-2-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra venit, vidit, dixit 06.04.2011 11:57:

Show 21 quoted lines

> Although the gitattributes page contains comprehensive information
> about these configuration options, they should be included in the
> config documentation for completeness.
> 
> Helped-by: Michael J Gruber <git@drmicha.warpmail.net>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  Documentation/config.txt |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 8ea55d4..654a3b8 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -973,6 +973,15 @@ format.signoff::
>      the rights to submit this work under the same open source license.
>      Please see the 'SubmittingPatches' document for further discussion.
>  
> +filter.<driver>.clean::
> +	The command which is used to convert the contents of worktree
> +	file upon checkin.  See linkgit:gitattributes[5] for details.

I don't want to be a PITA, but is there any particular reason you are refusing to use the article "a" even after repeated suggestions to use it? (Also, I suggested to say what we are converting into here.)

Show 6 quoted lines

> +
> +filter.<driver>.smudge::
> +	The command which is used to convert the blob object to
> +	worktree file upon checkout.  See linkgit:gitattributes[5] for
> +	details.
> +

You see, before my first response in this thread I thought: "Doing this myself would be less work than replying and explaining things, but I'll try to be nice."

Now, this is v4, I've even provided complete sentences ready for copy & paste, and we're still iterating. It turned out to be *much more* work than doing it myself. I'm sorry but I can't afford to spend even more time on this.

>  gc.aggressiveWindow::
>  	The window size parameter used in the delta compression
>  	algorithm used by 'git gc --aggressive'.  This defaults