git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [minor] two tests broken when run with a --root directory that's a symlink

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 11, 2012, 23:26 UTC
Message-ID
<7vpq4o615e.fsf@alter.siamese.dyndns.org>
In-Reply-To
<50774D25.6000403@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 7 quoted lines
> I ran into the same problem a while ago, and submitted a patch series
> that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):
>
>     http://thread.gmane.org/gmane.comp.version-control.git/206633
>
> Junio didn't like the approach so much and I haven't yet had time to
> submit a revised version.

I like the approach of comparing each element of CEILING and the directory not before but after resolving any symlinks in them.

My comments was only about the implementation that seemed to make the API layering boundary more complex than necessary.

Previous: Michael Haggerty
Message 4 of 4 in “[minor] two tests broken when run with a --root directory that's a symlink”
  1. Ævar Arnfjörð BjarmasonOct 11, 2012
  2. bash prompt: fix tests when run with a symlink --rootSZEDER Gábor, Oct 11, 2012
  3. Michael HaggertyOct 11, 2012
  4. Junio C HamanoOct 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.