From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 11 Oct 2012 23:26:37 GMT
Subject: Re: [minor] two tests broken when run with a --root directory that's a symlink
Message-ID: <7vpq4o615e.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50774D25.6000403@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> I ran into the same problem a while ago, and submitted a patch series
> that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):
>
>     http://thread.gmane.org/gmane.comp.version-control.git/206633
>
> Junio didn't like the approach so much and I haven't yet had time to
> submit a revised version.

I like the approach of comparing each element of CEILING and the
directory not before but after resolving any symlinks in them.

My comments was only about the implementation that seemed to make
the API layering boundary more complex than necessary.