Re: [minor] two tests broken when run with a --root directory that's a symlink

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Oct 11, 2012, 22:50 UTC
Message-ID: <50774D25.6000403@alum.mit.edu>
In-Reply-To: <CACBZZX6Cu_4X=AywsDMebdoFYdEN1Gmp439aEAcehHBuMhziTw@mail.gmail.com>

On 10/11/2012 11:55 PM, Ævar Arnfjörð Bjarmason wrote:

Show 19 quoted lines

> These issues are minor, I noticed it because I test with /dev/shm/git
> as the --root, which on Debian is symlinked to /run/..
> 
>     $ rm -rf /tmp/{foo,bar}
>     $ mkdir /tmp/target; ln -s /tmp/target /tmp/link
>     $ prove ./t4035-diff-quiet.sh ./t9903-bash-prompt.sh :: --root=/tmp/target
>     ./t4035-diff-quiet.sh ... ok
>     ./t9903-bash-prompt.sh .. ok
>     All tests successful.
>     Files=2, Tests=64,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.07
> cusr  0.06 csys =  0.17 CPU)
>     Result: PASS
>     $ prove ./t4035-diff-quiet.sh ./t9903-bash-prompt.sh :: --root=/tmp/link
>     ./t4035-diff-quiet.sh ... Dubious, test returned 1 (wstat 256, 0x100)
>     Failed 3/20 subtests
>     ./t9903-bash-prompt.sh .. Dubious, test returned 1 (wstat 256, 0x100)
>     Failed 6/44 subtests
> 
> Everything else in the test suite passes with a --root that's a symlink.

I ran into the same problem a while ago, and submitted a patch series that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):

    http://thread.gmane.org/gmane.comp.version-control.git/206633

Junio didn't like the approach so much and I haven't yet had time to submit a revised version.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/