Re: [PATCH 1/2] Fix "git diff" setup code

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2007, 19:11 UTC
Message-ID: <7vodg59i4x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.0.999.0709141129451.16478@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 8 quoted lines

> On Fri, 14 Sep 2007, Junio C Hamano wrote:
>> 
>> So I tend to think the attached is a better fix.
>
> Ahh, yes, that explains the conditional. 
>
> But whatever gets us to actually verify our options, and fill in the right 
> defaults is ok by me!

Sorry, my explanation only explains about missing setup_done() when --no-index is used, but does not explain _if_ you actually found that setup_done() was not called for you when you did a real life test. Was it only from code inspection, or did you hit a case where setup_done() is not run? If the latter then there is something else going on, as I cannot think of a way to call setup_revisions() and not have it call setup_done()...