git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Fix "git diff" setup code

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Sep 14, 2007, 19:46 UTC
Message-ID
<alpine.LFD.0.999.0709141238290.16478@woody.linux-foundation.org>
In-Reply-To
<7vodg59i4x.fsf@gitster.siamese.dyndns.org>
On Fri, 14 Sep 2007, Junio C Hamano wrote:
Show 6 quoted lines
> 
> Sorry, my explanation only explains about missing setup_done()
> when --no-index is used, but does not explain _if_ you actually
> found that setup_done() was not called for you when you did a
> real life test.  Was it only from code inspection, or did you
> hit a case where setup_done() is not run?

Hmm. Mea culpa. What seems to have happened is that I ran things under gdb, and noticed that the default rename_limit hadn't been correctly set: but now that I look more at it, that particular session was probably from "git runstatus", not "git diff".

So yeah, ignore my 1/2. It was almost certainly based on a bogus debugging session, before I noticed that wt-status.c doesn't use the normal diff stuff at all..

			Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 13 in “git-commit: Disallow unchanged tree in non-merge mode”
  1. 1/2 git-commit: Disallow unchanged tree in non-merge modeDmitry V. Levin, Sep 5, 2007
  2. Shawn O. PearceSep 6, 2007
  3. Dmitry V. LevinSep 6, 2007
  4. Linus TorvaldsSep 14, 2007
  5. 1/2 Fix "git diff" setup codeLinus Torvalds, Sep 14, 2007
  6. 2/2 Fix the rename detection limit checkingLinus Torvalds, Sep 14, 2007
  7. Linus TorvaldsSep 14, 2007
  8. Linus TorvaldsSep 14, 2007
  9. Junio C HamanoSep 14, 2007
  10. Linus TorvaldsSep 14, 2007
  11. Junio C HamanoSep 14, 2007
  12. Linus TorvaldsSep 14, 2007
  13. Junio C HamanoSep 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.