From: Junio C Hamano Date: Fri, 14 Sep 2007 19:11:42 GMT Subject: Re: [PATCH 1/2] Fix "git diff" setup code Message-ID: <7vodg59i4x.fsf@gitster.siamese.dyndns.org> In-Reply-To: Linus Torvalds writes: > On Fri, 14 Sep 2007, Junio C Hamano wrote: >> >> So I tend to think the attached is a better fix. > > Ahh, yes, that explains the conditional. > > But whatever gets us to actually verify our options, and fill in the right > defaults is ok by me! Sorry, my explanation only explains about missing setup_done() when --no-index is used, but does not explain _if_ you actually found that setup_done() was not called for you when you did a real life test. Was it only from code inspection, or did you hit a case where setup_done() is not run? If the latter then there is something else going on, as I cannot think of a way to call setup_revisions() and not have it call setup_done()...