Re: [PATCH] shrink git-shell by avoiding redundant dependencies
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2008, 21:55 UTC
- Message-ID
- <7vod5mpmp7.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1214602538-7888-1-git-send-email-dpotapov@gmail.com>
Dmitry Potapov <dpotapov@gmail.com> writes:
Show 18 quoted lines
> diff --git a/abspath.c b/abspath.c
> new file mode 100644
> index 0000000..4becedf
> --- /dev/null
> +++ b/abspath.c
> @@ -0,0 +1,80 @@
> +/*
> + * I'm tired of doing "vsnprintf()" etc just to open a
> + * file, so here's a "return static buffer with printf"
> + * interface for paths.
> + *
> + * It's obviously not thread-safe. Sue me. But it's quite
> + * useful for doing things like
> + *
> + * f = open(mkpath("%s/%s.git", base, name), O_RDONLY);
> + *
> + * which is what it's designed for.
> + */This is not a comment you would want to move to the resulting file that contains only make_absolute_path().