git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Remove function stubs in shell.c

From
Stephan Beyer <s-beyer@gmx.net>
Date
Jul 18, 2008, 01:06 UTC
Message-ID
<1216343197-20290-1-git-send-email-s-beyer@gmx.net>
In-Reply-To
<20080718005814.GA4155@spearce.org>

These function stubs may be useful, but because they redefine functions, they provoke a linker error.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Or would you rather like this one? ;)
 shell.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/shell.c b/shell.c
index 91ca7de..b27d01c 100644
--- a/shell.c
+++ b/shell.c
@@ -3,14 +3,6 @@
 #include "exec_cmd.h"
 #include "strbuf.h"
 
-/* Stubs for functions that make no sense for git-shell. These stubs
- * are provided here to avoid linking in external redundant modules.
- */
-void release_pack_memory(size_t need, int fd){}
-void trace_argv_printf(const char **argv, const char *fmt, ...){}
-void trace_printf(const char *fmt, ...){}
-
-
 static int do_generic_cmd(const char *me, char *arg)
 {
 	const char *my_argv[4];
-- 
1.5.6.3.390.g7b30
Previous: Johannes SchindelinNext: Dmitry Potapov
Message 11 of 16 in “shrink git-shell by avoiding redundant dependencies”
  1. shrink git-shell by avoiding redundant dependenciesDmitry Potapov, Jun 27, 2008
  2. Junio C HamanoJun 27, 2008
  3. Dmitry PotapovJun 27, 2008
  4. Junio C HamanoJun 27, 2008
  5. Stephan BeyerJul 18, 2008
  6. Shawn O. PearceJul 18, 2008
  7. Link git-shell only to a subset of libgit.aStephan Beyer, Jul 18, 2008
  8. Shawn O. PearceJul 18, 2008
  9. Dmitry PotapovJul 18, 2008
  10. Johannes SchindelinJul 18, 2008
  11. Remove function stubs in shell.cStephan Beyer, Jul 18, 2008
  12. Dmitry PotapovJul 18, 2008
  13. Dmitry PotapovJul 18, 2008
  14. Johannes SchindelinJun 28, 2008
  15. Dmitry PotapovJun 28, 2008
  16. Johannes SchindelinJun 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.