Re: [PATCH] shrink git-shell by avoiding redundant dependencies

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 18, 2008, 00:58 UTC
Message-ID: <20080718005814.GA4155@spearce.org>
In-Reply-To: <20080718002620.GE8421@leksak.fem-net>

Stephan Beyer <s-beyer@gmx.net> wrote:

Show 10 quoted lines

> >  
> > +/* Stubs for functions that make no sense for git-shell. These stubs
> > + * are provided here to avoid linking in external redundant modules.
> > + */
> > +void release_pack_memory(size_t need, int fd){}
> > +void trace_argv_printf(const char **argv, const char *fmt, ...){}
> > +void trace_printf(const char *fmt, ...){}
> 
> I don't really understand why this works.
> You redefine libgit.a functions here

On Solaris you cannot compile git with the Solaris compiler and linker, as the linker will not put up with the duplicate definition of these functions.

I told my co-worker who is taking over "that git stuff" from me at day-job to post a message to the list, or look at the Solaris manual pages and figure out what he needs to do in the Makefile to get it to work right. Neither has happened yet, and those day-job systems are the only Solaris boxen I touch, so I won't be fixing it anytime soon myself.

I have to wonder why its important we avoid linking to all of libgit.a here. So what if git-shell is a little bigger? This is certainly not fully portable, and does give warnings on some systems.

-- 
Shawn.