git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add NO_RSYNC to allow building without rsync

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 30, 2008, 20:11 UTC
Message-ID
<7vod4f3zfu.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080730185225.GG10399@yugib.highrise.ca>
Aidan Van Dyk <aidan@highrise.ca> writes:
> This is similar to NO_CURL.
I am not sure if this is a good change.

We link with libcurl so supporting NO_CURL makes sense for an environment without the library, but for rsync transport we just spawn it as a separate process. The net effect on a machine without rsync installed is the same (you cannot use rsync transport), but you can later choose to install rsync and things will start working without recompiling git.

Show 5 quoted lines
> Signed-off-by: Aidan Van Dyk <aidan@highrise.ca>
> ---
>
> I came about this because SCO OpenServer doesnt' have mkdtemp.  But I never use
> rsync, so making it optional was an easy fix.

Perhaps "make NO_MKDTEMP=YesPlease" is a much better fix for your particular environment?

The patch is seriously whitespace damaged, in any case.
Previous: Aidan Van DykNext: Aidan Van Dyk
Message 4 of 6 in “Add NO_RSYNC to allow building without rsync”
  1. Add NO_RSYNC to allow building without rsyncAidan Van Dyk, Jul 30, 2008
  2. Linus TorvaldsJul 30, 2008
  3. Aidan Van DykJul 30, 2008
  4. Junio C HamanoJul 30, 2008
  5. Aidan Van DykJul 30, 2008
  6. Boyd Lynn GerberJul 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.