From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Jul 2008 20:11:01 GMT
Subject: Re: [PATCH] Add NO_RSYNC to allow building without rsync
Message-ID: <7vod4f3zfu.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080730185225.GG10399@yugib.highrise.ca>

Aidan Van Dyk <aidan@highrise.ca> writes:

> This is similar to NO_CURL.

I am not sure if this is a good change.

We link with libcurl so supporting NO_CURL makes sense for an environment
without the library, but for rsync transport we just spawn it as a
separate process.  The net effect on a machine without rsync installed is
the same (you cannot use rsync transport), but you can later choose to
install rsync and things will start working without recompiling git.

> Signed-off-by: Aidan Van Dyk <aidan@highrise.ca>
> ---
>
> I came about this because SCO OpenServer doesnt' have mkdtemp.  But I never use
> rsync, so making it optional was an easy fix.

Perhaps "make NO_MKDTEMP=YesPlease" is a much better fix for your
particular environment?

The patch is seriously whitespace damaged, in any case.