Re: [PATCH] Add NO_RSYNC to allow building without rsync

From: Aidan Van Dyk <aidan@highrise.ca>
Date: Jul 30, 2008, 19:49 UTC
Message-ID: <20080730194905.GI10399@yugib.highrise.ca>
In-Reply-To: <alpine.LFD.1.10.0807301231050.3334@nehalem.linux-foundation.org>

* Linus Torvalds <torvalds@linux-foundation.org> [080730 15:42]:

Show 12 quoted lines

> Hmm. Without mkdtemp(), maybe you could just do a trivial compat function 
> somethin glike
> 
> 	char *git_mkdtemp(char *template)
> 	{
> 		char *n = mktemp(template);
> 		if (mkdir(n))
> 			n = NULL;
> 		return n;
> 	}
> 
> instead?

And as I go to whip that up (ya, I'm lazy and just needed a prod), I see it's already done:

# Define NO_MKDTEMP if you don't have mkdtemp in the C library.

But since rsync isn't available on this compile anyways, I still think NO_RSYNC is worth having on it's own, just like NO_CURL or NO_TCLTK

a.

-- 
Aidan Van Dyk                                             Create like a god,
aidan@highrise.ca                                       command like a king,
http://www.highrise.ca/                                   work like a slave.