git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote-curl: Add sanity check for url

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2010, 23:45 UTC
Message-ID
<7voci5qspr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<f3271551003301308y683173f6y6a4fadb01b791049@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Previously, `git remote-http foo` and subsquent commands would try to
> work on a HTML page. This patch fixes the bug by making one assumption
> about the URL handled by libcurl: it must contain the string "://"
I may be being slow but I do not see the point of this patch.

I thought that remote-foo is never invoked directly from a command line with random arguments, and fetch/push frontends make the decision based on the shape of the "URL" (or whatever data used to reach the remote end) which helper to run.

I do not think your patch would _break_ anything, but my question is more about the reason why we would want a duplicated check here.

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 2 of 3 in “remote-curl: Add sanity check for url”
  1. remote-curl: Add sanity check for urlRamkumar Ramachandra, Mar 30, 2010
  2. Junio C HamanoMar 30, 2010
  3. Ramkumar RamachandraMar 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.