From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 30 Mar 2010 23:45:36 GMT
Subject: Re: [PATCH] remote-curl: Add sanity check for url
Message-ID: <7voci5qspr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <f3271551003301308y683173f6y6a4fadb01b791049@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Previously, `git remote-http foo` and subsquent commands would try to
> work on a HTML page. This patch fixes the bug by making one assumption
> about the URL handled by libcurl: it must contain the string "://"

I may be being slow but I do not see the point of this patch.

I thought that remote-foo is never invoked directly from a command line
with random arguments, and fetch/push frontends make the decision based on
the shape of the "URL" (or whatever data used to reach the remote end)
which helper to run.

I do not think your patch would _break_ anything, but my question is more
about the reason why we would want a duplicated check here.