Re: [PATCH] remote-curl: Add sanity check for url
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Mar 31, 2010, 02:43 UTC
- Message-ID
- <u2tf3271551003301943sf703e66fz4274135efd991430@mail.gmail.com>
- In-Reply-To
- <7voci5qspr.fsf@alter.siamese.dyndns.org>
Hi,
> I may be being slow but I do not see the point of this patch.
Agreed, it's not a bug that any end-user would normally bump into. I bumped into this myself when I assumed that the remote `foo` exists, and invoked `git-remote-http foo`. Since remote_get() transparently creates a remote when one does not exist, remote-curl doesn't know if the remote `foo` ever really exists. Going off to fetch a HTML page when an expected remote doesn't exist is really ugly, so I thought I'd prepare this patch. Plus, it doesn't hurt to make sure that the remote helper conforms to the documentation- useful when a developer is calling it independently.
-- Ram