Re: [PATCH 1/2] Remove useless temporary integer in builtin/push.c
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 2, 2010, 18:51 UTC
- Message-ID
- <7vocdklueo.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <70ee84752cb7db08c65c608a12ed321dd2c26830.1280580026.git.jaredhance@gmail.com>
Jared Hance <jaredhance@gmail.com> writes:
> Creating a variable nr here to use throughout the function only to change > refspec_nr to nr at the end, having not used refspec_nr the entire time, > is rather pointless. Instead, simply increment refspec_nr.
That is something a compiler can notice and optimize out, so it byitself is not a good criteria to judge this change. The real issue is if the use of temporary makes the code easier to read or harder.
With the two patches squashed together to use ALLOC_GROW(), the result conforms to the pattern many codepaths use, and that makes it easier to read.
Will queue, with these two squashed into one commit.
Thanks.
Show 30 quoted lines
> Signed-off-by: Jared Hance <jaredhance@gmail.com>
> ---
> builtin/push.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/push.c b/builtin/push.c
> index f4358b9..79d8192 100644
> --- a/builtin/push.c
> +++ b/builtin/push.c
> @@ -25,10 +25,9 @@ static int refspec_nr;
>
> static void add_refspec(const char *ref)
> {
> - int nr = refspec_nr + 1;
> - refspec = xrealloc(refspec, nr * sizeof(char *));
> - refspec[nr-1] = ref;
> - refspec_nr = nr;
> + refspec_nr++;
> + refspec = xrealloc(refspec, refspec_nr * sizeof(char *));
> + refspec[refspec_nr-1] = ref;
> }
>
> static void set_refspecs(const char **refs, int nr)
> --
> 1.7.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html