git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove useless temporary integer in builtin/push.c

From
Thomas Rast <trast@student.ethz.ch>
Date
Jul 29, 2010, 22:21 UTC
Message-ID
<201007300021.34061.trast@student.ethz.ch>
In-Reply-To
<70ee84752cb7db08c65c608a12ed321dd2c26830.1280419073.git.jaredhance@gmail.com>
Jared Hance wrote:
Show 5 quoted lines
> Creating a variable nr here to use throughout the function only to change
> refspec_nr to nr at the end, having not used refspec_nr the entire time,
> is rather pointless. Instead, simply increment refspec_nr.
> 
> Signed-off-by: Jared Hance <jaredhance@gmail.com>
[...]
Show 7 quoted lines
> -	int nr = refspec_nr + 1;
> -	refspec = xrealloc(refspec, nr * sizeof(char *));
> -	refspec[nr-1] = ref;
> -	refspec_nr = nr;
> +	refspec_nr++;
> +	refspec = xrealloc(refspec, refspec_nr * sizeof(char *));
> +	refspec[refspec_nr-1] = ref;

While you're already here, you could switch to ALLOC_GROW instead to avoid the n**2 behaviour of xrealloc...

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Jared HanceNext: Jared Hance
Message 2 of 6 in “Remove useless temporary integer in builtin/push.c”
  1. Remove useless temporary integer in builtin/push.cJared Hance, Jul 29, 2010
  2. Thomas RastJul 29, 2010
  3. 0/2 Clean up add_refspec in builtin/push.cJared Hance, Jul 31, 2010
  4. 1/2 Remove useless temporary integer in builtin/push.cJared Hance, Jul 31, 2010
  5. Junio C HamanoAug 2, 2010
  6. 2/2 Use ALLOC_GROW in builtin/push.cJared Hance, Jul 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.