Re: [PATCH 0/2] Improve git-bundle builtin
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 15, 2011, 21:30 UTC
- Message-ID
- <7vobv9msjl.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1323967528-10537-1-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 5 quoted lines
> A couple of thoughts: > > 1. There's a SP between the OBJID and the ref name in list-heads as > opposed to the TAB used by other git commands such as ls-remote, > diff-tree. Will fixing it break someone's parser somewhere?
If somebody will get broken when you change something, that change is not "fixing" but just "changing". Why do you even want to "fix" it?
> 2. Is it worth fixing the "--stdin" tests? What is the usecase?
Having to pack too many refs that would not fit on a command line length limit, which is not an unusual requirement.