Re: [PATCH 0/2] Improve git-bundle builtin
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Dec 15, 2011, 20:54 UTC
- Message-ID
- <20111215205340.GA16160@elie.hsd1.il.comcast.net>
- In-Reply-To
- <1323967528-10537-1-git-send-email-artagnon@gmail.com>
Hi Ram,
Ramkumar Ramachandra wrote:
> 1. There's a SP between the OBJID and the ref name in list-heads as > opposed to the TAB used by other git commands such as ls-remote, > diff-tree. Will fixing it break someone's parser somewhere?
I don't know. Would there be any advantage at all to changing the output format of the tool? Bad idea.
If the goal is to avoid confusion, perhaps a note in the documentation would help.
> 2. Is it worth fixing the "--stdin" tests? What is the usecase?
Is "script that wants to list which revs to bundle, possibly exceeding the command-line length limit" not enough of a use case? Yes, I think it is very much worth fixing.
Thanks for looking at this. Jonathan