Re: [PATCH 2/2] bundle: rewrite builtin to use parse-options

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 8, 2011, 16:39 UTC
Message-ID: <20111208163946.GB2394@elie.hsd1.il.comcast.net>
In-Reply-To: <1323349817-15737-4-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

Show 10 quoted lines

> -	if (argc < 3)
> -		usage(builtin_bundle_usage);
> -
> -	cmd = argv[1];
> -	bundle_file = argv[2];
> -	argc -= 2;
> -	argv += 2;
> +	argc = parse_options(argc, argv, NULL,
> +			options, builtin_bundle_usage,
> +			PARSE_OPT_KEEP_ARGV0 | PARSE_OPT_KEEP_UNKNOWN);

Doesn't this make the usage completely confusing? Before, if I wanted to create bundle named "verify", I could write

	git bundle create verify

Afterwards, not only does that not work, but if I make a typo and write

	git bundle ceate verify

then it will act like "git bundle verify ceate".

I am starting to suspect the first half of patch 1/2 was not such a great idea, either. :) Do you have other examples of how it would be used?

Thanks for thining about these things, and hope that helps. Jonathan