git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN.

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 27, 2012, 22:59 UTC
Message-ID
<7vobn0yfm8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120727224554.GA30385@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> writes:
Show 25 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> Eric Wong <normalperson@yhbt.net> writes:
>> > The redundant dependencies are biting us :<  I agree there presence in
>> > the top-level Makefile needs to be reviewed.
>> 
>> Do you feel confident enough that we can leave that question hanging
>> around and still merge this before 1.7.12 safely?
>
> Yes.
>
>> I do not think it is a regression at the Makefile level per-se---we
>> didn't have right dependencies to keep perl.mak up to date, which
>> was the root cause of what we observed.
>> 
>> But the lack of dependencies did not matter before this series
>> because the list of *.pm files never changed, so in that sense the
>> series is what introduced the build regression, and I do not have a
>> solid feeling that we squashed it.
>
> Right, I agree the original dependencies are not good and it's not
> a recent regression in the Makefile level.
>
> I do feel our patch deals with the problem for now.  I've been going
> between commits in Michael's 3rd series and haven't noticed new issues
> when running the tests.

Ok, please don't forget to add necessary .gitignore rule for the new stamp file.

Previous: Eric WongNext: Eric Wong
Message 26 of 30 in “Extract Git::SVN from git-svn, take 2.”
  1. Michael G. SchwernJul 26, 2012
  2. 1/4 Extract some utilities from git-svn to allow extracting Git::SVN.Michael G. Schwern, Jul 26, 2012
  3. Junio C HamanoJul 27, 2012
  4. Michael G SchwernJul 27, 2012
  5. Eric WongJul 27, 2012
  6. 2/4 Prepare Git::SVN for extraction into its own file.Michael G. Schwern, Jul 26, 2012
  7. Junio C HamanoJul 27, 2012
  8. Junio C HamanoJul 27, 2012
  9. Michael G SchwernJul 27, 2012
  10. Eric WongJul 27, 2012
  11. 4/4 Move initialization of Git::SVN variables into Git::SVN.Michael G. Schwern, Jul 26, 2012
  12. Junio C HamanoJul 27, 2012
  13. Jonathan NiederJul 27, 2012
  14. Junio C HamanoJul 27, 2012
  15. Junio C HamanoJul 27, 2012
  16. Junio C HamanoJul 27, 2012
  17. Eric WongJul 27, 2012
  18. Michael G SchwernJul 27, 2012
  19. Eric WongJul 27, 2012
  20. Junio C HamanoJul 27, 2012
  21. Junio C HamanoJul 27, 2012
  22. Eric WongJul 27, 2012
  23. Eric WongJul 27, 2012
  24. Junio C HamanoJul 27, 2012
  25. Eric WongJul 27, 2012
  26. Junio C HamanoJul 27, 2012
  27. Eric WongJul 27, 2012
  28. Junio C HamanoJul 27, 2012
  29. Eric WongJul 27, 2012
  30. Michael G SchwernJul 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.