Re: [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN.
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Jul 27, 2012, 22:45 UTC
- Message-ID
- <20120727224554.GA30385@dcvr.yhbt.net>
- In-Reply-To
- <7vboj0zv7t.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Eric Wong <normalperson@yhbt.net> writes: > > The redundant dependencies are biting us :< I agree there presence in > > the top-level Makefile needs to be reviewed. > > Do you feel confident enough that we can leave that question hanging > around and still merge this before 1.7.12 safely?
Yes.
Show 8 quoted lines
> I do not think it is a regression at the Makefile level per-se---we > didn't have right dependencies to keep perl.mak up to date, which > was the root cause of what we observed. > > But the lack of dependencies did not matter before this series > because the list of *.pm files never changed, so in that sense the > series is what introduced the build regression, and I do not have a > solid feeling that we squashed it.
Right, I agree the original dependencies are not good and it's not a recent regression in the Makefile level.
I do feel our patch deals with the problem for now. I've been going between commits in Michael's 3rd series and haven't noticed new issues when running the tests.