Re: What's cooking in git.git (topics)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2007, 07:10 UTC
Message-ID: <7vmyuzbbif.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.0.999.0710021916080.3579@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> Hmm. The patch depends on half-way subtle issues like the fact that the 
> hashtables are guaranteed to not be full => we're guaranteed to have zero 
> counts at the end => we don't need to do any steenking iterator count in 
> the loop. A few comments might in order.

The patch actually is quite readable. That double-loop finding the matching hashval in destination hash was simply silly to begin with, so even if this is not "orders of magnitude" improvement, I think your patch is worth doing.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.