Re: What's cooking in git.git (topics)

From: Carlos Rica <jasampler@gmail.com>
Date: Sep 26, 2007, 21:07 UTC
Message-ID: <1b46aba20709261407g51fa83e2la96e712ffdd905c2@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0709150047030.28586@racer.site>

2007/9/15, Johannes Schindelin <Johannes.Schindelin@gmx.de>:

Show 16 quoted lines

> On Fri, 14 Sep 2007, Junio C Hamano wrote:
>
> > * cr/reset (Fri Sep 14 01:19:30 2007 -0700) 5 commits
> >  + Simplify cache API
> >  + An additional test for "git-reset -- path"
> >  + Make "git reset" a builtin.
> >  + Move make_cache_entry() from merge-recursive.c into read-cache.c
> >  + Add tests for documented features of "git reset".
> >
> > I found "git reset commit paths..." had problem in this series,
> > which was why jc/cachetree is merged into this topic to fix it.
> > Hopefully we can put this in 'master' soon, after giving it
> > another and final round of eyeballing.
>
> I think this is my bug.  The initial reset-with-paths functionality in the
> builtin reset came out of my feather... Sorry!

I'm sorry for not being able to review that code, but now it was a bit too hard for my current knowledge of the git's internals. These days I'm very busy here and I cannot continue with that work, but I will be soon in git to learn more. Please, be free to rework the code of builtin-reset.c without waiting for me if anyone is interested in get it done ASAP.

-- Carlos