From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Oct 2007 07:10:48 GMT
Subject: Re: What's cooking in git.git (topics)
Message-ID: <7vmyuzbbif.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.0.999.0710021916080.3579@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> Hmm. The patch depends on half-way subtle issues like the fact that the 
> hashtables are guaranteed to not be full => we're guaranteed to have zero 
> counts at the end => we don't need to do any steenking iterator count in 
> the loop. A few comments might in order.

The patch actually is quite readable.  That double-loop finding
the matching hashval in destination hash was simply silly to
begin with, so even if this is not "orders of magnitude"
improvement, I think your patch is worth doing.