git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Fix config lockfile handling.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 14, 2007, 20:07 UTC
Message-ID
<7vmysdqbui.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<Pine.LNX.4.64.0712141928240.27959@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
> Hi,
>
> On Fri, 14 Dec 2007, Kristian Høgsberg wrote:
>
>> -	struct lock_file *lock = NULL;
>> +	struct lock_file lock;
>
> AFAICT this cannot work.  At least not reliably.  An atexit() handler will 
> access all (even closed) lockfiles.
Correct.  It cannot be on the stack.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 8 in “config.c fixes”
  1. Kristian HøgsbergDec 14, 2007
  2. 1/2 Fix config lockfile handling.Kristian Høgsberg, Dec 14, 2007
  3. 2/2 Use a strbuf for building up section header and key/value pair strings.Kristian Høgsberg, Dec 14, 2007
  4. Johannes SchindelinDec 14, 2007
  5. Junio C HamanoDec 14, 2007
  6. Johannes SchindelinDec 14, 2007
  7. Junio C HamanoDec 14, 2007
  8. Johannes SixtDec 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.