From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Dec 2007 20:07:33 GMT
Subject: Re: [PATCH 1/2] Fix config lockfile handling.
Message-ID: <7vmysdqbui.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0712141928240.27959@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Fri, 14 Dec 2007, Kristian Høgsberg wrote:
>
>> -	struct lock_file *lock = NULL;
>> +	struct lock_file lock;
>
> AFAICT this cannot work.  At least not reliably.  An atexit() handler will 
> access all (even closed) lockfiles.

Correct.  It cannot be on the stack.