Re: [PATCH 1/2] Fix config lockfile handling.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 14, 2007, 20:15 UTC
Message-ID: <Pine.LNX.4.64.0712142015240.27959@racer.site>
In-Reply-To: <7vmysdqbui.fsf@gitster.siamese.dyndns.org>

Hi,

On Fri, 14 Dec 2007, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Fri, 14 Dec 2007, Kristian Høgsberg wrote:
> >
> >> -	struct lock_file *lock = NULL;
> >> +	struct lock_file lock;
> >
> > AFAICT this cannot work.  At least not reliably.  An atexit() handler 
> > will access all (even closed) lockfiles.
> 
> Correct.  It cannot be on the stack.

Note that this behaviour will be another obstacle to libification.

Ciao, Dscho