git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix amending of a commit with an empty message

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 21, 2008, 20:56 UTC
Message-ID
<7vmyput4dn.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080221203802.GB20143@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
> In this one. I am a bit unsure regarding the change (it looks a little
> too strong), even though it passes the test suite.
I think that is because your new test is faulty.

Instead of ':' I complained about, try having "echo foo" there. I think it will still fail.

So your test failure is not about "a commit with an empty message" at all.

Look at the previous test and how we allow an empty commit (not "with empty message", but "with the same tree as its sole parent") to be made and amended.

Having said that, here is a quiz. When the user says "git commit --amend", what are the valid reasons not to allow it, other than:

 - the index is unmerged.
 - the branch is yet to be born.
Previous: Alex RiesenNext: Alex Riesen
Message 5 of 8 in “A test for commit --amend allowing changing of a very empty commit message”
  1. A test for commit --amend allowing changing of a very empty commit messageAlex Riesen, Feb 21, 2008
  2. Junio C HamanoFeb 21, 2008
  3. Alex RiesenFeb 21, 2008
  4. Fix amending of a commit with an empty messageAlex Riesen, Feb 21, 2008
  5. Junio C HamanoFeb 21, 2008
  6. Alex RiesenFeb 21, 2008
  7. Junio C HamanoFeb 21, 2008
  8. Johannes SchindelinFeb 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.