Re: [PATCH] Fix amending of a commit with an empty message

From: Alex Riesen <raa.lkml@gmail.com>
Date: Feb 21, 2008, 21:32 UTC
Message-ID: <20080221213204.GC20143@steel.home>
In-Reply-To: <7vmyput4dn.fsf@gitster.siamese.dyndns.org>

Junio C Hamano, Thu, Feb 21, 2008 21:56:52 +0100:

Show 9 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > In this one. I am a bit unsure regarding the change (it looks a little
> > too strong), even though it passes the test suite.
> 
> I think that is because your new test is faulty.
> 
> Instead of ':' I complained about, try having "echo foo" there.
> I think it will still fail.

Oh, indeed. The commit to amend does not introduce any changes.

Show 6 quoted lines

> Having said that, here is a quiz.  When the user says "git
> commit --amend", what are the valid reasons not to allow it,
> other than:
> 
>  - the index is unmerged.
>  - the branch is yet to be born.

There are no tree changes in the commit to be amended. And if there is a strong wish to do just the amendment, there is always --allow-empty.

Ok, it must have been the amount of err... tee I just had.