git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] A test for commit --amend allowing changing of a very empty commit message

From
Alex Riesen <raa.lkml@gmail.com>
Date
Feb 21, 2008, 20:35 UTC
Message-ID
<20080221203506.GA20143@steel.home>
In-Reply-To
<7vwsoyt5xt.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Thu, Feb 21, 2008 21:23:10 +0100:
Show 5 quoted lines
> Alex Riesen <raa.lkml@gmail.com> writes:
> >
> > Well, it fails... In current master
> 
> Then please mark it with test_expect_failure.
That's because I expect it to be fixed (in the next mail)
Show 6 quoted lines
> > +test_expect_success 'allow amend of an empty message' '
> > +
> > +	git reset --hard &&
> > +	sha=$(:|git commit-tree HEAD^{tree} -p HEAD) &&
> 
> You do not have to pipe; </dev/null would do ;-).
Sadly: no. There are very challenged systems. Like, for instance, ones
having no idea of what "/dev/null" is. Windows/Cygwin/ActiveState Perl
in a bloody stupid corporate combination.

I'm trying to minimize differences between my tree for my system at work and the main tree. It is honestly the only purpose for this construct.

Previous: Junio C HamanoNext: Alex Riesen
Message 3 of 8 in “A test for commit --amend allowing changing of a very empty commit message”
  1. A test for commit --amend allowing changing of a very empty commit messageAlex Riesen, Feb 21, 2008
  2. Junio C HamanoFeb 21, 2008
  3. Alex RiesenFeb 21, 2008
  4. Fix amending of a commit with an empty messageAlex Riesen, Feb 21, 2008
  5. Junio C HamanoFeb 21, 2008
  6. Alex RiesenFeb 21, 2008
  7. Junio C HamanoFeb 21, 2008
  8. Johannes SchindelinFeb 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.