Re: [PATCH] git-remote: fixed missing .uploadpack usage for show command

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2009, 18:32 UTC
Message-ID: <7vmy7wcgge.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090625090036.GA32650@foursquare.net>

Chris Frey <cdfrey@foursquare.net> writes:

> When using 'git remote show <name>', the remote HEAD check
> did not use the uploadpack configuration setting.
>
> Signed-off-by: Chris Frey <cdfrey@foursquare.net>

Thanks.

"X did not use Y" may be a good statement of the fact. From the patch text it can be seen that a NULL used to be passed and the patch makes it to pass states->remote instead, so "This patch make X use Y", even though left unsaid in the message, can be seen.

But it does not answer a more important question. How was it a problem that "X did not use Y"?

People who followed a recent discussion know the answer to this question, but ones who read this in the "git log" output 6 months down the line will not. Please make a habit of justifying the change by stating "why".

"X should have used Y because of such and such reasons, but it didn't. Instead of showing the correct result W, it gave Z, which may happen to be the same as W in default settings but otherwise is wrong."