git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-remote: fix missing .uploadpack usage for show command

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 25, 2009, 21:48 UTC
Message-ID
<7vd48s2ddr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090625212135.GA28935@foursquare.net>
Chris Frey <cdfrey@foursquare.net> writes:
Show 16 quoted lines
> For users pulling from machines with self compiled git installs,
> in non-PATH locations, they can set the config option
> remote.<name>.uploadpack to set the location of git-upload-pack.
>
> When using 'git remote show <name>', the remote HEAD check
> did not use the uploadpack configuration setting, and would
> not use the configured program.
>
> In builtin-remote.c, the config setting is already loaded
> with the call to remote_get(), so this patch passes that remote
> along to transport_get().
>
> Signed-off-by: Chris Frey <cdfrey@foursquare.net>
> ---
>
> A possibly clearer description...
Thanks, much clearer.  Will queue, aiming to eventually merge to 'maint'.

Do you have tests to protect this fix from getting broken in the future by other people?

Previous: Chris Frey
Message 4 of 4 in “git-remote: fixed missing .uploadpack usage for show command”
  1. git-remote: fixed missing .uploadpack usage for show commandChris Frey, Jun 25, 2009
  2. Junio C HamanoJun 25, 2009
  3. git-remote: fixed missing .uploadpack usage for show commandChris Frey, Jun 25, 2009
  4. Junio C HamanoJun 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.