Re: [PATCH] git-remote: fix missing .uploadpack usage for show command
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 25, 2009, 21:48 UTC
- Message-ID
- <7vd48s2ddr.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20090625212135.GA28935@foursquare.net>
Chris Frey <cdfrey@foursquare.net> writes:
Show 16 quoted lines
> For users pulling from machines with self compiled git installs, > in non-PATH locations, they can set the config option > remote.<name>.uploadpack to set the location of git-upload-pack. > > When using 'git remote show <name>', the remote HEAD check > did not use the uploadpack configuration setting, and would > not use the configured program. > > In builtin-remote.c, the config setting is already loaded > with the call to remote_get(), so this patch passes that remote > along to transport_get(). > > Signed-off-by: Chris Frey <cdfrey@foursquare.net> > --- > > A possibly clearer description...
Thanks, much clearer. Will queue, aiming to eventually merge to 'maint'.
Do you have tests to protect this fix from getting broken in the future by other people?