git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-remote: fixed missing .uploadpack usage for show command

From
CFChris Frey <cdfrey@foursquare.net>
Date
Jun 25, 2009, 21:21 UTC
Message-ID
<20090625212135.GA28935@foursquare.net>
In-Reply-To
<7vmy7wcgge.fsf@alter.siamese.dyndns.org>

For users pulling from machines with self compiled git installs, in non-PATH locations, they can set the config option remote.<name>.uploadpack to set the location of git-upload-pack.

When using 'git remote show <name>', the remote HEAD check did not use the uploadpack configuration setting, and would stall.

In builtin-remote.c, the config setting is already loaded with the call to remote_get(), so this patch passes that remote along to transport_get().

Signed-off-by: Chris Frey <cdfrey@foursquare.net>
---
A possibly clearer description...
 builtin-remote.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index 658d578..ec1f903 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -787,7 +787,7 @@ static int get_remote_ref_states(const char *name,
 	read_branches();
 
 	if (query) {
-		transport = transport_get(NULL, states->remote->url_nr > 0 ?
+		transport = transport_get(states->remote, states->remote->url_nr > 0 ?
 			states->remote->url[0] : NULL);
 		remote_refs = transport_get_remote_refs(transport);
 		transport_disconnect(transport);
-- 
1.6.2.5
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “git-remote: fixed missing .uploadpack usage for show command”
  1. git-remote: fixed missing .uploadpack usage for show commandChris Frey, Jun 25, 2009
  2. Junio C HamanoJun 25, 2009
  3. git-remote: fixed missing .uploadpack usage for show commandChris Frey, Jun 25, 2009
  4. Junio C HamanoJun 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.