Re: [PATCH] Handle double slashes in make_relative_path()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 22, 2010, 03:05 UTC
- Message-ID
- <7vmy06et5c.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vpr52gbmu.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> I would actually have expected to see something like this, but I haven't > even compile tested it, so...
Ok, here is a compile and "make test" tested one, together with your addition to the test script.
I am still curious how you managed to end up with a wrong function name in the context header, though. The patch below has "set_shared_perm" because that is the header we find before the context of the hunk, so it is sort of understandable; we might want to squelch the hunk header string when the first context line of the hunk already matches the funcname pattern, though.
-- >8 -- Subject: ignore duplicated slashes in make_relative_path()
The function takes two paths, an early part of abs is supposed to match base; otherwise abs is not a path under base and the function returns the full path of abs. The caller can easily confuse the implementation by giving duplicated and needless slashes in these path arguments.
Credit for test script, motivation and initial patch goes to Thomas Rast, but the bugs in the implementation of this patch are mine..
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- path.c | 32 +++++++++++++++++++++++--------- t/t1501-worktree.sh | 6 ++++++ 2 files changed, 29 insertions(+), 9 deletions(-)
diff --git a/path.c b/path.c index 2ec950b..5906fa3 100644 --- a/path.c +++ b/path.c @@ -394,17 +394,31 @@ int set_shared_perm(const char *path, int mode) const char *make_relative_path(const char *abs, const char *base) { static char buf[PATH_MAX + 1]; - int baselen; + int i = 0, j = 0; + if (!base) return abs; - baselen = strlen(base); - if (prefixcmp(abs, base)) - return abs; - if (abs[baselen] == '/') - baselen++; - else if (base[baselen - 1] != '/') - return abs; - strcpy(buf, abs + baselen); + while (base[i]) { + if (base[i] == '/') { + if (abs[j] != '/') + return abs; + while (base[i] == '/') + i++; + while (abs[j] == '/') + j++; + continue; + } else if (abs[j] != base[i]) { + return abs; + } + i++; + j++; + } + while (abs[j] == '/') + j++; + if (!abs[j]) + strcpy(buf, "."); + else + strcpy(buf, abs + j); return buf; } diff --git a/t/t1501-worktree.sh b/t/t1501-worktree.sh index 74e6443..9df3012 100755 --- a/t/t1501-worktree.sh +++ b/t/t1501-worktree.sh @@ -189,4 +189,10 @@ test_expect_success 'absolute pathspec should fail gracefully' ' ) ' +test_expect_success 'make_relative_path handles double slashes in GIT_DIR' ' + : > dummy_file + echo git --git-dir="$(pwd)//repo.git" --work-tree="$(pwd)" add dummy_file && + git --git-dir="$(pwd)//repo.git" --work-tree="$(pwd)" add dummy_file +' + test_done