Re: [PATCH] Handle double slashes in make_relative_path()
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jan 23, 2010, 19:00 UTC
- Message-ID
- <201001232000.28896.j6t@kdbg.org>
- In-Reply-To
- <201001231448.42721.robin.rosenberg@dewire.com>
On Samstag, 23. Januar 2010, Robin Rosenberg wrote:
Show 11 quoted lines
> lördagen den 23 januari 2010 14.09.29 skrev Johannes Sixt: > > The function returns either the input unmodified, or it strips also at > > least one directory component, except when base is only "/" (or "//" or > > "///"...). I said in practice, because on Windows it does not make sense > > to invoke git with (literally) > > > > git --git-dir=//server/share/repo.git --work-tree=/ ... > > > > i.e., without a drive prefix before the slash of --work-tree. > > Why not? //foo/bar/z is just as valid and useful a path as x:/z.
Fortunately, make_relative_path() does not have the slightest problem with //foo/bar/z, either as value of abs (the path to make relative) or as base (the path to strip from abs).
-- Hannes